Teach PCT about Mina SSHD API plugins#375
Merged
jglick merged 1 commit intojenkinsci:masterfrom Jul 26, 2022
Merged
Conversation
jetersen
approved these changes
Jul 26, 2022
Member
Author
|
/reviewer @jenkinsci/teams/plugin-compat-tester-developers |
Member
Author
|
/label enhancement |
Member
Author
|
/reviewer @jenkinsci/plugin-compat-tester-developers |
Member
|
The bot has been turned off on most repos for now IIUC. |
jglick
approved these changes
Jul 26, 2022
Member
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
Design flaw in PCT that it even requires custom hooks for the routine case of a multimodule project, but in the meantime, we need this I guess.
Member
Author
One of many. 😀 |
Member
Not familiar with the thing you are discussing unfortunately. I recall a problem being worked around in #318. |
Member
Author
Well I linked to the code. I am even less familiar than you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered when running BOM/PCT tests with recent PCT bits in jenkinsci/bom#1059: although current BOM
masterbuilds appear fine with regard to the Mina SSHD API plugins, they are using an ancient and nonstandard version of PCT that fails to report many errors. Recent and unmodified PCT bits show errors like the ones from this run (specific log formina-sshd-api-core) andpct-report.xmlcontains<status>INTERNAL_ERROR</status>.This PR corrects the specific problem shown above by teaching PCT about the Mina SSHD API plugins, and I tested it in this run (see the corresponding build log for
mina-sshd-api-core). The build progresses further than before (as demonstrated by comparing the two build logs formina-sshd-api-core), although ultimately the tests formina-sshd-api-corestill do not get executed: unlike e.g.pipeline-stage-view(which triggers this code path, which works), the Mina SSHD API plugins are in a multi-module Maven project with JEP-229 enabled (which triggers this code path, skipping all tests because they are apparently not supported in multimodule Maven projects with JEP-229 enabled). I filed any latent curiousity about this gap in feature parity between JEP-229 and non-JEP-229 plugins for another day and decided to proceed with the current PR which at least improves the status quo. Besides, this PR is completely risk-free for anything other than the Mina SSHD API plugins, so merging it cannot hurt. And most importantly, it is the last thing standing in my way to completing jenkinsci/bom#1059.